fix(aws-sdk): calc propagation fields count before context inject #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
blumamir,
NathanielRN and
willarmiros
blumamir
reviewed
Nov 14, 2021
| @@ -64,7 +64,7 @@ export const injectPropagationContext = ( | |||
| attributesMap?: SQS.MessageBodyAttributeMap | SNS.MessageAttributeMap | |||
| ): SQS.MessageBodyAttributeMap | SNS.MessageAttributeMap => { | |||
| const attributes = attributesMap ?? {}; | |||
| if (Object.keys(attributes).length < MAX_MESSAGE_ATTRIBUTES) { | |||
| if (Object.keys(attributes).length + propagation.fields().length <= MAX_MESSAGE_ATTRIBUTES) { | |||
There was a problem hiding this comment.
can you please add a simple unit test for that?
blumamir
changed the title
blumamir
approved these changes
Jan 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 13 13
Lines 707 707
Branches 142 142
=======================================
Hits 671 671
Misses 36 36 |
rauno56
approved these changes
Jan 14, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Background: As described here, SQS/SNS services limited up to 10 message metadata attributes.
The instrumentation is checking if there are enough available attributes before adding more metadata attributes.
Before this pr, it ignored how many fields are going be added by applied propagators.
After this pr, it will check how many fields are going be added, to make sure not setting more than 10 message metadata attributes.